Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[brunocodutra-metal] Add new port #5817

Merged
merged 2 commits into from
Mar 31, 2019
Merged

[brunocodutra-metal] Add new port #5817

merged 2 commits into from
Mar 31, 2019

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Mar 26, 2019

No description provided.

@Rastaban
Copy link
Contributor

I see a failure on linux but passing on everything else:

Starting package 1/1: metal:x64-linux
Building package metal[core]:x64-linux... 
Could not locate cached archive: /home/vcpkg/myagent/_work/1/s/archives/de/dee7384292912a171e3831e4e3df322fd88ba558.zip
-- Downloading https://github.com/brunocodutra/metal/archive/v2.0.1.tar.gz...
-- Extracting source /home/vcpkg/myagent/_work/1/s/downloads/brunocodutra-metal-v2.0.1.tar.gz
-- Using source at /home/vcpkg/myagent/_work/1/s/buildtrees/metal/src/v2.0.1-cee2e39175
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:45 (message):
  
  '/home/vcpkg/myagent/_work/1/s/packages/metal_x64-linux/debug/lib/cmake/metal'
  does not exist.
Call Stack (most recent call first):
  ports/metal/portfile.cmake:20 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:71 (include)


Error: Building package metal:x64-linux failed with: BUILD_FAILED
Elapsed time for package metal:x64-linux: 4.604 s

install-x64-linux-dbg-out.log

Maybe case sensitivity (metal/Metal) from vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake/${PORT})

@ras0219-msft
Copy link
Contributor

To avoid confusion with the Apple software product Metal[1], I think this should probably be renamed to something like brunocodutra-metal.

[1] https://developer.apple.com/metal/

@myd7349
Copy link
Contributor Author

myd7349 commented Mar 27, 2019 •
edited
Loading

@Rastaban Thanks! I did not test it on Linux yet.
@ras0219-msft Thanks! I will take it into account.

@myd7349 myd7349 changed the title [metal] Add new port [brunocodutra-metal] Add new port Mar 30, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented Mar 31, 2019

Test project: https://github.com/myd7349/Ongoing-Study/tree/master/cpp/CMake/vcpkg/metal_example

Test with:

  • x86-windows
  • x86-windows-static
  • x64-windows
  • x64-windows-static
  • x64-linux

@Rastaban
Copy link
Contributor

Passes on all triplets

@Rastaban Rastaban merged commit 8757c64 into microsoft:master Mar 31, 2019
@myd7349 myd7349 deleted the metal-init branch March 31, 2019 23:23
@myd7349 myd7349 mentioned this pull request May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myd7349 @Rastaban @ras0219-msft